Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never bundle when saving as peer/peerOptional #255

Merged
merged 1 commit into from Mar 23, 2021
Merged

Conversation

@isaacs
Copy link
Collaborator

@isaacs isaacs commented Mar 19, 2021

There's a bit of logic in npm/cli that sets the saveBundle option to
false based on the various --save-xyz flags. It is easier and safer
to just never bundle if we're saving a peer dep, in the one place where
that decision is made.

References

There's a bit of logic in npm/cli that sets the `saveBundle` option to
false based on the various `--save-xyz` flags.  It is easier and safer
to just never bundle if we're saving a peer dep, in the one place where
that decision is made.

PR-URL: #255
Credit: @isaacs
Close: #255
@isaacs isaacs force-pushed the isaacs/never-bundle-peers branch from e582c52 to 22b2d13 Mar 23, 2021
@isaacs isaacs closed this in 22b2d13 Mar 23, 2021
@isaacs isaacs merged commit 22b2d13 into main Mar 23, 2021
54 of 56 checks passed
@ruyadorno ruyadorno mentioned this pull request Mar 23, 2021
@wraithgar wraithgar deleted the isaacs/never-bundle-peers branch Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant