This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
guard against locale-specific sorting #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/fix-locale-compare
branch
2 times, most recently
from
dc3590b
to
bf38e1b
Compare
|
This took a few rounds of updating all the deps in node-tap. Setting the |
This was referenced May 8, 2021
|
node-tap is updated in |
isaacs
force-pushed
the
isaacs/fix-locale-compare
branch
from
bf38e1b
to
8fbe794
Compare
Node will use the current environment's locale sorting for String.localeCompare. Thankfully, String.localeCompare can take a second argument to specify the locale. Up until Node 13, any valid argument provided to the function _may_ be respected if Node was compiled with Intl support, or would always be treated as `'en'` otherwise. The solution is to always set the locale to `'en'`. An alternative solution would be to compare strings based on byte order, but this does not provide ideal ergonomis. To verify this, the locale is set in the test environment to `'sk'`, which has a significantly different alphabet, including sorting words starting with `'ch'` _after_ words starting with `'d'`. Re: npm/cli#2829 Fix: #276
isaacs
force-pushed
the
isaacs/fix-locale-compare
branch
from
4b06448
to
a843eea
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node will use the current environment's locale sorting for
String.localeCompare. Thankfully, String.localeCompare can take a
second argument to specify the locale. Up until Node 13, any valid
argument provided to the function may be respected if Node was
compiled with Intl support, or would always be treated as
'en'otherwise.
The solution is to always set the locale to
'en'. An alternativesolution would be to compare strings based on byte order, but this does
not provide ideal ergonomis.
To verify this, the locale is set in the test environment to
'sk',which has a significantly different alphabet, including sorting words
starting with
'ch'after words starting with'd'.Re: npm/cli#2829
Fix: #276
References