This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
chore: add regression tests for old lockfile warning #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/old-lockfile-regression-test
branch
from
039d56e
to
90db053
Compare
Ref: npm/cli#3721 Prior to this change[^1] reifying with no package-lock or a package-lock with a merge conflict would result in an old lockfile warning. This adds regression tests to explicitly test both those scenarios. [^1]: c7f2370#diff-a22bf0383032b8f318ebe49a4e41b34bcc98e2c10d18322f619edcd041a27483R333-R334
lukekarrys
force-pushed
the
lk/old-lockfile-regression-test
branch
from
90db053
to
a5218da
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: npm/cli#3721
Prior to this change1 reifying with no package-lock or a package-lock
with a merge conflict would result in an old lockfile warning. This adds
regression tests to explicitly test both those scenarios.
Footnotes
https://github.com/npm/arborist/commit/c7f2370b3fa9111944b916871c281efba507732d#diff-a22bf0383032b8f318ebe49a4e41b34bcc98e2c10d18322f619edcd041a27483R333-R334 ↩