Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] test coverage #11

Closed
isaacs opened this issue Dec 9, 2019 · 0 comments
Closed

[BUG] test coverage #11

isaacs opened this issue Dec 9, 2019 · 0 comments

Comments

@isaacs
Copy link
Contributor

isaacs commented Dec 9, 2019

Expected: 100% coverage
Actual: not even close
isaacs added a commit that referenced this issue Dec 11, 2019
@isaacs
fix: prevent improper clobbering of man/bin links
8d57a42 
This uses the updated version of gentle-fs which has the binLink method,
so that we don't need to fork based on OS, and will always check to
ensure that the bin or cmd-shim is a reference into the folder being
linked.

Also perform a similar check on linked man pages.

Fix #11
isaacs added a commit that referenced this issue Dec 11, 2019
@isaacs
fix: prevent improper clobbering of man/bin links
1bb7310 
This uses the updated version of gentle-fs which has the binLink method,
so that we don't need to fork based on OS, and will always check to
ensure that the bin or cmd-shim is a reference into the folder being
linked.

Also perform a similar check on linked man pages.

Fix #11
@isaacs isaacs closed this as completed in 642cd18 Dec 11, 2019
@dependabot dependabot bot mentioned this issue Mar 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(deps): bump bin-links from 1.1.2 to 1.1.8 shahednasser/all-contributors
1 participant
@isaacs