feat(promise): removed bluebird

Author: billatnpm

lib/content/read.js

@@ -1,6 +1,5 @@
 'use strict'
 
-const BB = require('bluebird')
 const util = require('util')
 
 const contentPath = require('./path')
@@ -146,19 +145,36 @@ function withContentSri (cache, integrity, fn) {
       const cpath = contentPath(cache, digests[0])
       return fn(cpath, digests[0])
     } else {
-      return BB.any(sri[sri.pickAlgorithm()].map(meta => {
-        return withContentSri(cache, meta, fn)
-      }, { concurrency: 1 }))
-        .catch((err) => {
-          if ([].some.call(err, e => e.code === 'ENOENT')) {
-            throw Object.assign(
+      // Can't use race here because a generic error can happen before a ENOENT error, and can happen before a valid result
+      return Promise.all(sri[sri.pickAlgorithm()].map((meta) => {
+        return withContentSri(cache, meta, fn).catch((err) => {
+          if (err.code === 'ENOENT') {
+            return Object.assign(
               new Error('No matching content found for ' + sri.toString()),
               { code: 'ENOENT' }
             )
-          } else {
-            throw err[0]
           }
+          return err
         })
+      })).then((results) => {
+        // Return the first non error if it is found
+        const result = results.find((r) => !(r instanceof Error))
+        if (result) {
+          return result
+        }
+
+        // Throw the No matching content found error
+        const enoentError = results.find((r) => r.code === 'ENOENT')
+        if (enoentError) {
+          throw enoentError
+        }
+
+        // Throw generic error
+        const genericError = results.find((r) => r instanceof Error)
+        if (genericError) {
+          throw genericError
+        }
+      })
     }
   }
 

package-lock.json

@@ -58,7 +58,6 @@
   ],
   "license": "ISC",
   "dependencies": {
-    "bluebird": "^3.5.5",
     "chownr": "^1.1.1",
     "figgy-pudding": "^3.5.1",
     "glob": "^7.1.4",