fix(npm.output): make output go through npm.output #2795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
force-pushed
the
gar/npm-output
branch
from
419b9a4
to
8863fef
Compare
darcyclarke
added
Release 7.x
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Mar 1, 2021
This will allow for changing configs that are read by commands through flatOptions. Based of npm#2795, land that first. Relates to: npm#2765 Relates to: npm/rfcs#117
ruyadorno
approved these changes
Mar 1, 2021
wraithgar
force-pushed
the
gar/npm-output
branch
from
8863fef
to
edfc3bb
Compare
darcyclarke
removed
the
release: next
wraithgar
force-pushed
the
gar/npm-output
branch
from
edfc3bb
to
653930f
Compare
Yes this should be on our radar. |
darcyclarke
added
release: next
All output that anything wants to make now goes through `npm.output()`. This is an incremental change getting us closer to where we want to be with testing. PR-URL: #2795 Credit: @wraithgar Close: #2795 Reviewed-by: @ruyadorno, @isaacs
wraithgar
force-pushed
the
gar/npm-output
branch
from
653930f
to
eb9dac3
Compare
wraithgar
added a commit
that referenced
this pull request
Mar 9, 2021
All output that anything wants to make now goes through `npm.output()`. This is an incremental change getting us closer to where we want to be with testing. PR-URL: #2795 Credit: @wraithgar Close: #2795 Reviewed-by: @ruyadorno, @isaacs
Merged
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All output that anything wants to make now goes through
npm.output(). This is an incremental change getting uscloser to where we want to be with testing.
This is built off of #2772 which needs to be merged before this is really reviewable.