WIP: feat(workspaces): running cmds #2765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Feb 23, 2021
darcyclarke
added
semver:minor
ruyadorno
added a commit
to ruyadorno/rfcs
that referenced
this pull request
Feb 24, 2021
A lot of brainstorming sessions and OpenRFC call discussions have led to a number of substantial changes to the original proposed RFC. I'm now committing these changes in here so that we can further discuss and iron out any details while we progress with the work in the implementation. Ref: npm/cli#2765
Instead of files randomly requiring the npm singleton, we pass it where it needs to go so that tests don't need to do so much require mocking everywhere
All output that anything wants to make now goes through `npm.output()`. This is an incremental change getting us closer to where we want to be with testing.
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Mar 1, 2021
This will allow for changing configs that are read by commands through flatOptions. Relates to: npm#2765 Relates to: npm/rfcs#117
This will allow for changing configs that are read by commands through flatOptions. Based of npm#2795, land that first. Relates to: npm#2765 Relates to: npm/rfcs#117
ruyadorno
force-pushed
the
running-workspaces-cmds
branch
from
2136afb
to
f007920
Compare
darcyclarke
changed the title
darcyclarke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ongoing proof-of-concept, currently gathering feedback in the implementation.
Ref: npm/rfcs#117