version: update lock before lifecycle #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update version information in lock files before the main `version` lifecycle script is run. See https://npm.community/t/5135
isaacs
force-pushed
the
release-next
branch
2 times, most recently
from
896149d
to
31718e7
Compare
|
@larsgw sorry for the delay here. We now do this in npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update version information in lock files before the main
versionlifecycle script is run.
See https://npm.community/t/5135
Should probably include tests but that seems to require refactoring that particular test setup
and I don't feel like doing that right nowand I though, let's discuss the changes first.Also, I couldn't run the existing tests because they failed when run as a bunch but passed while run individually. Then they edited this very commit (?!), so I'm just going to let Travis-CI handle this.