Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced var with const for adduser.js #190

Closed
wants to merge 1 commit into from
Closed

Replaced var with const for adduser.js #190

wants to merge 1 commit into from

Conversation

jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented Apr 21, 2019 •
edited
Loading

@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner April 21, 2019 06:34
@jamesgeorge007
Copy link
Contributor Author

@zkat @aeschright Thoughts 🤔

@jamesgeorge007 jamesgeorge007 force-pushed the hotfix/code-cleanup branch 2 times, most recently from d640cd9 to ab8396b Compare April 21, 2019 07:57
colinrotherham
colinrotherham reviewed Apr 23, 2019
View reviewed changes
lib/adduser.js Outdated Show resolved Hide resolved
@isaacs isaacs added the semver:patch semver patch level for changes label Jun 26, 2019
@isaacs
Copy link
Contributor

isaacs commented Jun 26, 2019

In next release.

@isaacs
Copy link
Contributor

isaacs commented Jul 10, 2019

8d4effb

@isaacs isaacs closed this Jul 10, 2019
@f4lco0n f4lco0n mentioned this pull request Jun 28, 2023
Open
@nicholaschoi168 nicholaschoi168 mentioned this pull request Jun 28, 2023
Open
@MrBrain295 MrBrain295 mentioned this pull request May 20, 2024
Open
@mtdev2 mtdev2 mentioned this pull request May 20, 2024
Open
@baby636 baby636 mentioned this pull request May 21, 2024
Open
@bumplzz69 bumplzz69 mentioned this pull request May 21, 2024
Open
@Bhanditz Bhanditz mentioned this pull request May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinrotherham colinrotherham colinrotherham left review comments

Assignees
No one assigned
Labels
semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamesgeorge007 @isaacs @colinrotherham