Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**WIP** install: correctly exclude dev dependencies when using global and shrinkwrap #218

Closed
wants to merge 1 commit into from

Conversation

imrehg
Copy link

@imrehg imrehg commented Jul 23, 2019

@imrehg imrehg marked this pull request as ready for review July 23, 2019 17:29
@imrehg imrehg requested a review from a team as a code owner July 23, 2019 17:29
@imrehg
Copy link
Author

imrehg commented Jul 24, 2019

Checked the failed build log, obviously my previous simpler testing didn't catch these cases, and have to revisit it. Sorry about that, will update this PR appropriate later.

@imrehg imrehg changed the title install: correctly exclude dev dependencies when using global and shrinkwrap **WIP** install: correctly exclude dev dependencies when using global and shrinkwrap Jul 24, 2019
@imrehg imrehg closed this Jul 24, 2019
@scizor666
Copy link

scizor666 commented Jun 2, 2020

is there any hope the issue referenced here will be fixed soon? What's the official work around? Currently I'm trying to bypass this by the suggestion from #166

  • During prepack: npm prune --prod && rm npm-shrinkwrap.json && npm shrinkwrap Generates the shrinkwrap without devDeps
  • During postpack: git checkout -- npm-shrinkwrap.json && npm i restores devDeps and reinstalls what was removed during the prune.

is there a better way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants