Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @npmcli/run-script for exec, explore; add interactive exec #2202

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Use @npmcli/run-script for exec, explore; add interactive exec #2202

merged 2 commits into from
Dec 4, 2020

Commits on Dec 2, 2020

  1. Use @npmcli/run-script for exec, explore; add interactive exec 

    This removes all other arg/shell escaping mechanisms, as they are no
longer needed, and will be un-done by puka in @npmcli/run-script anyway.

Adds an interactive shell mode when `npm exec` is run without any
arguments, allowing users to interactively test out commands in an npm
script environment.  Previously, this would do nothing, and just exit.

Prevent weird behavior from `npm explore ../blah`.  `explore` now can
_only_ be used to explore packages that are actually found in the
relevant `node_modules` folder.
    @isaacs @darcyclarke
    isaacs authored and darcyclarke committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    15d7333 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Do not run interactive exec in CI when a TTY 

    Credit: @isaacs
PR-URL: #2202
Close: #2202
Reviewed-by: @darcyclarke

PR-URL: #2202
Credit: @isaacs
Close: #2202
Reviewed-by: @ruyadorno
    @isaacs @ruyadorno
    isaacs authored and ruyadorno committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    4f94d42 View commit details
    Browse the repository at this point in the history