Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove process.umask() call from config default #2444

Merged
merged 1 commit into from
Jan 7, 2021

Commits on Jan 7, 2021

  1. Remove process.umask() call from config default

    Since we now are using pacote/tar in a way that will rely on the default
    process umask setting, and we set file/directory modes explicitly
    anyway, there's no need to have a default umask setting that calls
    process.umask()
    
    As this method is not worker-thread safe, and is deprecated, it's best
    for us to stop using it.
    
    Fix: #1103
    
    PR-URL: #2444
    Credit: @isaacs
    Close: #2444
    Reviewed-by: @nlf
    isaacs committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    d01746a View commit details
    Browse the repository at this point in the history