-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: skip publishing some unnecessary files #2851
Conversation
I'd like to give it a try at our release integration with nodejs to make sure it doesn't prune any of the expected files there, for instance |
the node release integration clones this repo, it doesn't use the tarball. It can't since the tarball doesn't include the tests themselves either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
.mailmap | ||
changelogs/* | ||
configure | ||
make.bat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to check to make sure that the install.sh
isn't calling ./configure
or make
, but these are fine to leave out.
ddc4535
to
b0ae548
Compare
at a glance, these do not appear necessary to ship with the tarball and don't really make sense for most end users.
these changes reduce the published tarball by ~300kb and the installed size by ~1mb
References