Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add --dry-run to npm install #41

Merged
merged 1 commit into from Aug 20, 2018

Conversation

@reconbot
Copy link
Contributor

@reconbot reconbot commented Aug 8, 2018

No description provided.

@reconbot reconbot requested a review from as a code owner Aug 8, 2018
Copy link
Contributor

@zkat zkat left a comment

This looks good. I'd really like this to be added to the npm pack docs, since they both support --dry-run now. Do you mind doing that?

@reconbot reconbot force-pushed the reconbot/install-docs branch from a66d576 to fb90d5f Aug 9, 2018
@reconbot reconbot force-pushed the reconbot/install-docs branch from fb90d5f to 406a843 Aug 9, 2018
@reconbot
Copy link
Contributor Author

@reconbot reconbot commented Aug 9, 2018

Happy to, updated the commit and message and improved the language a bit.

zkat
zkat approved these changes Aug 13, 2018
Copy link
Contributor

@zkat zkat left a comment

Looks good! Thanks!

@zkat zkat removed the in-progress label Aug 13, 2018
styfle
styfle approved these changes Aug 14, 2018
@reconbot
Copy link
Contributor Author

@reconbot reconbot commented Aug 16, 2018

looks like a stalled test

zkat
zkat approved these changes Aug 20, 2018
Copy link
Contributor

@zkat zkat left a comment

Thank you! This looks great. I really hope it helps more people learn about --dry-run on these two commands, which is super handy sometimes 👍

@zkat zkat changed the base branch from latest to release-next Aug 20, 2018
@zkat zkat merged commit e2c4aea into npm:release-next Aug 20, 2018
1 of 2 checks passed
1 of 2 checks passed
@travis-ci[bot]
Travis CI - Pull Request Build Failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
zkat added a commit that referenced this issue Aug 20, 2018
@reconbot
Copy link
Contributor Author

@reconbot reconbot commented Aug 21, 2018

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants