Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): more complete commit message formatting #4216

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Jan 6, 2022

  • switches from messageHeadline to message to avoid truncated commit messages
  • instead of removing all instances of (#\d+) only removes those which we're adding our own link to
  • wraps package@1.0.0 type patterns in backticks

@nlf nlf requested a review from a team as a code owner January 6, 2022 22:46
@nlf nlf force-pushed the nlf/fix-changelog-commit-message branch from 4f1f4f7 to 49b3d6f Compare January 6, 2022 22:49
@npm-robot
Copy link
Contributor

npm-robot commented Jan 6, 2022

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 50.914 ±9.84 27.025 ±0.13 15.905 ±0.01 18.305 ±0.78 2.663 ±0.03 2.685 ±0.03 2.144 ±0.00 10.558 ±0.09 2.152 ±0.01 2.903 ±0.06
#4216 0.377 ±0.00 0.382 ±0.00 0.377 ±0.00 0.373 ±0.00 0.377 ±0.00 0.375 ±0.00 0.378 ±0.01 0.376 ±0.00 0.377 ±0.00 0.382 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 34.326 ±1.30 21.059 ±0.04 11.894 ±0.13 12.649 ±0.50 2.464 ±0.02 2.443 ±0.02 2.181 ±0.01 7.951 ±0.03 2.048 ±0.01 2.600 ±0.13
#4216 0.376 ±0.00 0.380 ±0.00 0.378 ±0.00 0.380 ±0.01 0.375 ±0.00 0.378 ±0.00 0.381 ±0.00 0.402 ±0.02 0.380 ±0.00 0.379 ±0.00

@nlf nlf merged commit 3b93654 into release-next Jan 6, 2022
@nlf nlf deleted the nlf/fix-changelog-commit-message branch January 6, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants