-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve workspace paths from cwd when possible #4265
Conversation
Would this encourage use of prefix in npmrc or the env? using prefix breaks nvm and sometimes termux, so it’d be ideal not to increase usage of it. |
found 20 benchmarks with statistically significant performance improvements
timing results
|
very valid point. i've tweaked the changes to |
107ccf3
to
5e571b7
Compare
moved to ready for review since this can land independently of the |
relates to: npm/rfcs#343 |
these are changes that are required along with landing and publishing npm/config#28 (and updating it here) to enable automatic detection of a workspace root.
this fix stands on its own, however. if a user had the structure
and they ran
npm test -w ./a
from within/workspaces/
, they would currently get an error. this corrects that behavior so we resolve the path fora
based onprocess.cwd()
instead of the workspace root.the above comment is not directly related to this pull request, but i wanted to keep it here for posterity