Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update npm-registry-fetch (and pacote and npm-profile) #4326

Merged
merged 4 commits into from
Jan 26, 2022

Conversation

wraithgar
Copy link
Member

  • deps: pacote@12.0.3
  • deps: npm-profile@6.0.0
  • deps: npm-registry-fetch@12.0.1

@wraithgar wraithgar requested a review from a team as a code owner January 25, 2022 19:20
@wraithgar wraithgar changed the title deps: npm-registry-fetch update npm-registry-fetch (and pacote and npm-profile) Jan 25, 2022
@npm-robot
Copy link
Contributor

npm-robot commented Jan 25, 2022

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 49.801 ±0.26 29.218 ±0.18 32.184 ±21.58 19.725 ±0.80 2.852 ±0.01 2.888 ±0.02 2.321 ±0.01 11.574 ±0.46 2.270 ±0.01 3.871 ±0.80
#4326 0.401 ±0.02 0.404 ±0.01 0.390 ±0.00 0.389 ±0.00 0.389 ±0.00 0.385 ±0.00 0.384 ±0.00 0.389 ±0.00 0.390 ±0.00 0.386 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 37.353 ±0.97 22.488 ±0.09 12.379 ±0.10 13.916 ±0.48 2.521 ±0.01 2.522 ±0.01 2.272 ±0.01 8.287 ±0.08 2.109 ±0.02 3.393 ±0.66
#4326 0.394 ±0.00 0.397 ±0.01 0.387 ±0.00 0.396 ±0.00 0.391 ±0.00 0.408 ±0.02 0.390 ±0.00 0.394 ±0.00 0.390 ±0.00 0.391 ±0.00

Copy link
Contributor

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just take a look to confirm but it seems to me that these are unwanted deps popping up on arborist, otherwise the rest of updates looks fine 👍

workspaces/arborist/package.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@ruyadorno ruyadorno merged commit 90c384c into release-next Jan 26, 2022
@ruyadorno ruyadorno deleted the deps/npm-registry-fetch branch January 26, 2022 20:51
@wraithgar wraithgar mentioned this pull request Jan 27, 2022
@JeromeFitz JeromeFitz mentioned this pull request Feb 11, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants