-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package unpublished and 404 cleanup #4572
Conversation
Going to also add a commit removing the "bug the author" message on a 404. |
That seems like a registry change that would break older and current clients; can the registry send that value even if modern npm isn’t using it? |
Seeing a related PR, how is it a privacy concern to tell me my own name? |
The registry doesn't send that anymore, so this cleans the message up. Having the npm registry send dummy data there for old clients would be something you can request via https://www.npmjs.com/support |
Right, but why did the registry stop sending that info? and when was that breaking change announced? |
It is no longer returned from the npm registry
478cc81
to
62e21c8
Compare
no statistically significant performance changes detected timing results
|
Two commits here, one removes the user name from the unpublished message, as that's no longer returned by the npm registry. The second one removes the "bug the author" message from the package 404, that copy is outdated and from a different era.