-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(version): reify on workspace version change #4588
Conversation
cdaa79a
to
883fa8f
Compare
Adds a minimalistic reify step that updates the installed tree after a version change within one of the configured workspaces when using any of the workspaces config options. It's also possible to use the `--save` config option in order to auto update semver ranges of dependencies declarations accross dependent `package.json` files. Fixes: npm#3403 Relates to: npm/rfcs#556 Relates to: npm#3757 Relates to: npm#4193
883fa8f
to
9eb120d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes look good to me, however i do think it's probably a good idea to document this more explicitly in the workspaces docs with examples of exactly what will happen when it's used.
that can be a follow up pull request, though, so i'm marking this approved as-is
Thanks @nlf that's a great idea! I know that page is in need of some love, I was chatting with @bnb the other day that was also noticing it could use more consistent naming across the examples there. With that in mind I'll pb take the time this week to work on a small revamp/clean up of that page and will make sure to also add examples and notes about this behavior 🤔 although it might be better to land these doc updates after we also add this similar behavior to |
Adds a minimalistic reify step that updates the installed tree after initializing a new workspace. Moved the shared update logic from `lib/commands/version.js` to a `lib/workspaces/update-workspaces.js` module that is reused between both `npm version` and `npm init`. Relates to: npm/rfcs#556 Relates to: npm#4588
Adds a minimalistic reify step that updates the installed tree after initializing a new workspace. Moved the shared update logic from `lib/commands/version.js` to a `lib/workspaces/update-workspaces.js` module that is reused between both `npm version` and `npm init`. Relates to: npm/rfcs#556 Relates to: npm#4588
Adds a minimalistic reify step that updates the installed tree after initializing a new workspace. Moved the shared update logic from `lib/commands/version.js` to a `lib/workspaces/update-workspaces.js` module that is reused between both `npm version` and `npm init`. Relates to: npm/rfcs#556 Relates to: npm#4588
Adds a minimalistic reify step that updates the installed tree after initializing a new workspace. Moved the shared update logic from `lib/commands/version.js` to a `lib/workspaces/update-workspaces.js` module that is reused between both `npm version` and `npm init`. Relates to: npm/rfcs#556 Relates to: #4588
Sorry to come back to this PR so late, but I think I just noticed this new behavior. Does this change mean it's no longer possible to do a very simple |
@fritzy I just stumbled accross this PR because I still have issues with In Thus, I wouldn't consider #3403 as closed. Anyhow - thanks a ton for the great work, this is highly appreciated. Steps to reproduce
|
@Regaddi There's a |
I was looking for this feature and had the same problem as @manuth with the option seemingly not working to update the versions of the package in dependencies within the workspace root. |
Adds a minimalistic reify step that updates the installed tree after a
version change within one of the configured workspaces when using any
of the workspaces config options.
It's also possible to use the
--save
config option in order toauto update semver ranges of dependencies declarations accross dependent
package.json
files.References
Fixes: #3403
Relates to: npm/rfcs#556
Relates to: #3757
Relates to: #4193