deps: @npmcli/template-oss@3.2.2 #4639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukekarrys
commented
Mar 29, 2022
•
lukekarrys
commented
- add some basic tests for docs
- make dockhand script work on windows
- cleanup main CI to match template-oss
- add a git status check for cli ci tests
- use resetdeps for ci steps
lukekarrys
force-pushed
the
lk/ci-cleanup
branch
3 times, most recently
from
e6df61b
to
58e8a61
Compare
|
no statistically significant performance changes detected timing results
|
lukekarrys
force-pushed
the
lk/ci-cleanup
branch
14 times, most recently
from
752a2c0
to
a419ca7
Compare
lukekarrys
changed the title
- add some basic tests for docs - make dockhand script work on windows - cleanup main CI to match template-oss - add a git status check for cli ci tests - use resetdeps for ci steps
lukekarrys
force-pushed
the
lk/ci-cleanup
branch
from
a419ca7
to
f2271b0
Compare
wraithgar
reviewed
Mar 30, 2022
wraithgar
reviewed
Mar 30, 2022
wraithgar
reviewed
Mar 30, 2022
wraithgar
approved these changes
Mar 30, 2022
template-oss does support this, which i just pushed a fixup to do. i left the platform matrix in there because i fixed a windows bug with the doc creation script. |
lukekarrys
commented
Mar 30, 2022
| - run: node ./bin/npm-cli.js run smoke-tests --ignore-scripts | ||
| - name: git status | ||
| if: matrix.platform.os != 'windows-latest' | ||
| run: node scripts/git-dirty.js |
There was a problem hiding this comment.
I wanted to highlight that I could not get the git-dirty check to work on windows. I'm ok with that for now, but this might lead to problems for external contributors on windows.
This was referenced Apr 6, 2022
This was referenced Aug 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.