Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor / inline single use code #5859

Merged
merged 1 commit into from
Nov 16, 2022
Merged

fix: refactor / inline single use code #5859

merged 1 commit into from
Nov 16, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Nov 15, 2022 •
edited
Loading

No description provided.

@wraithgar wraithgar requested a review from a team as a code owner November 15, 2022 15:46
@wraithgar wraithgar changed the title gar/arborist cleanup fix: refactor / inline single use code Nov 15, 2022
nlf
nlf approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much simpler 👍

i checked here and found that lib/place-dep.js has no setters, this is important because if it did these changes could potentially have triggered changes in behavior too. this one looks all clear, though!

@wraithgar wraithgar merged commit 3f13818 into latest Nov 16, 2022
@wraithgar wraithgar deleted the gar/arborist-cleanup branch November 16, 2022 17:55
@github-actions github-actions bot mentioned this pull request Nov 16, 2022
Merged
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wraithgar @nlf