Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readable-stream@3.0.2 #59

Closed
wants to merge 1 commit into from
Closed

readable-stream@3.0.2 #59

wants to merge 1 commit into from

Conversation

jmannanc
Copy link
Contributor

@jmannanc jmannanc requested a review from a team as a code owner August 26, 2018 02:13
@zkat
Copy link
Contributor

zkat commented Aug 26, 2018

The reason we don't update readable-stream right now is because there needs to be a single copy of it in the entire tree, and there's a lot of packages that still rely on the legacy version. All those packages need to be updated (possibly with 2 || 3), or we'll get a ton more stuff in the tree, as you can see, and we'll still be running various bits of r-s@2. Not having a single copy also wreaks havoc in some places because it does instanceof checks and we do a lot of stream work :/

@jmannanc
Copy link
Contributor Author

So if I go to those packages repos that depend on readable-stream and update it to 3.0.2 in a PR or something, then this could be merged? Along with updated versions of all the other packages that depend on readable-stream?

@zkat
Copy link
Contributor

zkat commented Aug 26, 2018

@sneakyfish5 if you do that, and it doesn't break anything else, then yes. Would be good to look into what the breaking changes actually are, too.

@jmannanc
Copy link
Contributor Author

I can get to work on trying to update the packages that depend on readable-stream if you think 3.0.2 won't break anything. The breaking changes are here: https://github.com/nodejs/readable-stream#version-3xx

I don't know if any of them will apply to NPM, do you?

@zkat
Copy link
Contributor

zkat commented Aug 28, 2018

@SneakyFish I'm suspicious about at least 2, 4, 6, and 8. But the only way to really find out is to roll it out and see what happens.

@jmannanc
Copy link
Contributor Author

Ok cool I'll get working on that then. Is there a way to mark this PR as WIP?

@isaacs
Copy link
Contributor

isaacs commented Jun 26, 2019

readable-stream@3.3.0 will be in the next release.

antongolub pushed a commit to antongolub-forks/npm-cli that referenced this pull request May 18, 2024
BREAKING CHANGE: this module no longer attempts to change file ownership automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants