fix: rethrow error when script failed

[MichaelBitard]

Fixes #6399

It rethrows the error after being catched and printed.

This allows the exit-handler:

cli/lib/utils/exit-handler.js

Lines 220 to 223 in 829503b

	let flushed = 0
	const flush = [process.stderr, process.stdout]
	const exit = () => ++flushed === flush.length && process.exit(exitCode)
	flush.forEach((f) => f.write('', exit))

to catch the error and propagate the error

[wraithgar]

Not throwing was intentional here. Running scripts in workspace mode is not intended to end immediately following the first error. This is also only a check for if there is no script w/ that name, so that you can run npm run x -ws and any workspaces with an x script will run it, and any that are missing will be ok. It's essentially an implicit --if-present mode.

At the end if ALL scripts were missing an error throws

cli/lib/commands/run-script.js

Line 226 in 15ccf87

throw new Error(`Missing script: ${args[0]}`)

If we want to make the --if-present explicit we would have to do that in a semver major (npm 10 is coming up) and make this code check that config and throw if it's not true. That's a wholly separate thing though.

If you want to try your hand at the breaking change feel free to make a PR for that. As it is though this PR is not something we can accept.

[MichaelBitard]

Thanks for the detailed explanations!

The main issue is : when one script fails, the npm command ends without an error code.
That breaks a lot of things, and I thought re-throwing the error was the correct way (and I was wrong :))

Do you know how we could fix this issue?

[wraithgar]

It is not supposed to exit with an error code. The implied --if-present is why. It only errors if they are all missing.

[wraithgar]

Or do you mean if the script is present but exits uncleanly? Is this happening in every node version?

[wraithgar]

If it's only in node20 this is the bug #6399

[MichaelBitard]

Yes it's only on node20, and this current PR was trying to fix #6399 :)

That's why I'm asking you if you have some insights on how to fix this

[wraithgar]

Ah I'm happy to help. I'll ping you in 6399 cause it has nothing to do w/ run-script.