Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore node prereleases in npm engines check #6574

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Jun 19, 2023

They don't currently have any so that code would never have mattered

cf https://nodejs.org/download/release/

@wraithgar wraithgar requested a review from a team as a code owner June 19, 2023 20:07
@wraithgar
Copy link
Member Author

Gonna have to get clever in the test fixture

@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Jun 19, 2023

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 35.080 ±2.38 19.409 ±0.05 19.039 ±0.03 21.248 ±0.09 3.102 ±0.03 3.092 ±0.03 2.661 ±0.07 12.900 ±0.03 2.577 ±0.04 3.849 ±0.16 0.434 ±0.01 0.473 ±0.01
#6574 36.029 ±2.91 19.850 ±0.06 19.220 ±0.20 21.622 ±0.14 3.071 ±0.01 3.165 ±0.03 2.631 ±0.00 13.195 ±0.12 2.591 ±0.01 3.754 ±0.11 0.455 ±0.01 0.504 ±0.01
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 26.570 ±1.48 15.170 ±0.04 14.745 ±0.24 15.886 ±0.09 2.779 ±0.05 2.797 ±0.01 2.522 ±0.08 9.800 ±0.28 2.395 ±0.02 3.426 ±0.12 0.426 ±0.00 0.475 ±0.00
#6574 26.162 ±1.48 15.339 ±0.11 14.850 ±0.05 16.162 ±0.16 2.812 ±0.00 2.874 ±0.03 2.561 ±0.04 10.165 ±0.10 2.432 ±0.01 3.399 ±0.00 0.447 ±0.01 0.510 ±0.01

test/lib/cli-entry.js Outdated Show resolved Hide resolved
lib/cli-entry.js Outdated Show resolved Hide resolved
@wraithgar
Copy link
Member Author

https://nodejs.org/download/release/

Do we even need the flag at all?

@lukekarrys
Copy link
Contributor

https://nodejs.org/download/release/

Do we even need the flag at all?

At the risk of prematurely optimizing, if Node ever did ship a prerelease we would want that flag (and the template-oss PR). So I think for the sake of having the code match our intent (even if it's not currently possible), we should land both PRs.

They don't currently have any so that code would never have mattered

cf https://nodejs.org/download/release/
@wraithgar wraithgar force-pushed the gar/node-version-prerelease branch from 0b8902e to c420756 Compare June 20, 2023 16:47
@wraithgar wraithgar changed the title fix: use includePrerelease flag when checking node version fix: ignore node prereleases in npm engines check Jun 20, 2023
@wraithgar wraithgar merged commit 939a188 into latest Jun 20, 2023
@wraithgar wraithgar deleted the gar/node-version-prerelease branch June 20, 2023 17:00
@github-actions github-actions bot mentioned this pull request Jun 20, 2023
lukekarrys pushed a commit that referenced this pull request Jun 20, 2023
They don't currently have any so that code would never have mattered

cf https://nodejs.org/download/release/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants