-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore node prereleases in npm engines check #6574
Conversation
Gonna have to get clever in the test fixture |
no statistically significant performance changes detected timing results
|
https://nodejs.org/download/release/ Do we even need the flag at all? |
At the risk of prematurely optimizing, if Node ever did ship a prerelease we would want that flag (and the template-oss PR). So I think for the sake of having the code match our intent (even if it's not currently possible), we should land both PRs. |
They don't currently have any so that code would never have mattered cf https://nodejs.org/download/release/
0b8902e
to
c420756
Compare
They don't currently have any so that code would never have mattered cf https://nodejs.org/download/release/
They don't currently have any so that code would never have mattered
cf https://nodejs.org/download/release/