-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update publish docs: dist-tag + publish case #7560
Conversation
Also the tag that is added to the package@version specified by the \`npm | ||
tag\` command, if no explicit tag is given. | ||
Also the tag that is added to the package@version specified by the | ||
\`npm dist-tag add\` command, if no explicit tag is given. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The grammar of this sentence was not and still is not correct.
"The tag is also added to ... "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read it several times and thought something was wrong but wasn't 100% sure as not a native English speaker.
The tag is also added
for me sounds like same tag is added in two places, whilst they're describing two different scenarios (what happens for the config / CLI arg in npm i
vs npm dist-tag add
.
Updated it to be:
It is the tag added to the package@version specified in the
npm dist-tag add
command, if no explicit tag is given.
Changed also the by
-> in
as the users specifies the package@version
to the command (it's not the command the one specifying that string)
Though suggestions very welcome ofc
With feedback from @mbtools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Updates
publish
command docs:npm tag
which is nownpm dist-tag
npm publish --tag
References