This repository has been archived by the owner on Nov 3, 2022. It is now read-only.
load non-scoped auth configs, scoped to default registry #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/fix-top-level-auth-reading
branch
from
3c9ac9f
to
2dcab91
Compare
isaacs
changed the title
isaacs
force-pushed
the
isaacs/fix-top-level-auth-reading
branch
from
2dcab91
to
6595c31
Compare
isaacs
changed the title
The legacy CouchDB style registries require an email in order to authenticate. However, the email itself is never used as part of the auth process after the initial account creation. There is no need for it to be scoped to a given registry or required in order to use _auth with a base64 encoded username/password basic auth pair. Also, add support for a registry-scoped _auth field. I'm not sure why that was removed in the first place, since npm-registry-fetch will parse it, so we need to be moving a top-level _auth field under the default registry, for all the same reasons we do so for tokens.
wraithgar
approved these changes
Apr 23, 2021
nlf
approved these changes
Apr 23, 2021
|
Related: npm/cli#3130 |
We don't actually use always-auth anymore. There is no reason to manage it as part of the registry-specific auth keys. PR-URL: #16 Credit: @isaacs Close: #16 Reviewed-by: @wraithgar, @nlf
isaacs
force-pushed
the
isaacs/fix-top-level-auth-reading
branch
from
6a7871f
to
0ac3605
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References