This repository has been archived by the owner on Nov 16, 2019. It is now read-only.
[api] login option for application/x-www-form-urlencoded #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doublerebel
force-pushed
the
master
branch
13 times, most recently
from
28f45ef
to
59a1712
Compare
|
As we can see in the build history something about Node 0.8 causes the tests to fail when manipulating the password. It seems the tests were never fully passing on Node 0.8 anyway, since they relied on I've fixed the Couch setup so that it detects Travis and adjusts permissions to successfully run in the Travis environment. Now all tests are passing, including the one added per my PR. Thanks for your work, would love to get this merged! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Cloudant requires form encoding for logins, but accepts JSON otherwise. This patch enables the form encoding and is backwards-compatible.
I had some trouble getting the tests to run locally, but I don't see this causing any regressions. Since Travis is setup for this repo I can make sure this PR passes all tests before merge.
Thanks!