Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "url.URL is not a constructor" error on Node 6 < v6.13.0 #61

Closed
billneff79 opened this issue Feb 26, 2020 · 1 comment
Closed

[BUG] "url.URL is not a constructor" error on Node 6 < v6.13.0 #61

billneff79 opened this issue Feb 26, 2020 · 1 comment
Assignees
Labels

Comments

@billneff79
Copy link

@billneff79 billneff79 commented Feb 26, 2020

What / Why

The unit tests (and actual usage in the wild) fail with the error:
"url.URL is not a constructor"

When

I run the unit tests or use the package on Node v6 (which seems to be supported?) with a version less than v6.13.0, where the URL constructor was first introduced to Node v6.

Where

All places

How

Current Behavior

  • Run unit tests on Node v6 < v6.13.0 (e.g. v6.12.3) and notice the error

Steps to Reproduce

  • Run unit tests on Node v6 < v6.13.0 (e.g. v6.12.3) and notice the error

Expected Behavior

  • Running unit tests on all versions of Node v6 passes without error

Who

References

Introduced in PR #58
https://github.com/npm/hosted-git-info/pull/58/files#diff-168726dbe96b3ce427e7fedce31bb0bcR112

isaacs added a commit that referenced this issue Feb 26, 2020
Fix #61

This should not be ported to the latest branch, as Node.js v6 support
was dropped there anyway.
billneff79 added a commit to billneff79/hosted-git-info that referenced this issue Feb 26, 2020
isaacs added a commit that referenced this issue Feb 26, 2020
Fix #61

This should not be ported to the latest branch, as Node.js v6 support
was dropped there anyway.

PR-URL: #62
Credit: @isaacs
Close: #62
Reviewed-by: @isaacs
@darcyclarke darcyclarke self-assigned this Feb 29, 2020
@darcyclarke darcyclarke added this to the OSS - Sprint 5 milestone Feb 29, 2020
darcyclarke added a commit that referenced this issue Feb 29, 2020
…ssed node 6 support
darcyclarke added a commit that referenced this issue Feb 29, 2020
…ssed node 6 support
darcyclarke added a commit that referenced this issue Feb 29, 2020
…ssed node 6 support

PR-URL: #66
Credit: @darcyclarke
Close: #66
Reviewed-by: @darcyclarke
@darcyclarke
Copy link
Member

@darcyclarke darcyclarke commented Feb 29, 2020

This should be fixed by #66 which was landed in hosted-git-info@2.8.8. We'll try to roll out a cli update as soon as possible which will include this dep update (likely as npm@6.14.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants