Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Failed to parse git url #60

Closed
link89 opened this issue Feb 26, 2020 · 1 comment
Closed

[BUG] Failed to parse git url #60

link89 opened this issue Feb 26, 2020 · 1 comment
Labels

Comments

@link89
Copy link

@link89 link89 commented Feb 26, 2020

Hi, I think the new version just breaks the git URL parser.

var whatwg = new url.URL(giturl)

Now it failed to handle dependency like this:
git+ssh://git@git.unlucky.com:RND/electron-tools/some-tool#2.0.1

Can you release a hotfix for this? It breaks a lot of things and hard to work around in projects.

node version: 12.0.0

@isaacs
@darcyclarke

@isaacs
Copy link
Member

@isaacs isaacs commented Feb 26, 2020

Confirmed, we'll take a look at this today.

@darcyclarke darcyclarke added this to the OSS - Sprint 5 milestone Feb 26, 2020
isaacs added a commit that referenced this issue Feb 26, 2020
Fix #60
isaacs added a commit that referenced this issue Feb 26, 2020
Fix #60 (for the legacy branch)
billneff79 added a commit to billneff79/hosted-git-info that referenced this issue Feb 26, 2020
@isaacs isaacs closed this in 0835306 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants