fix(config): rework load order and support builtin configs

Author: zkat

README.md

@@ -26,17 +26,15 @@ console.log('configured registry:', config.read({
 
 ### API
 
-##### <a name="read"></a> `> read(moreOpts, readOpts)`
+##### <a name="read"></a> `> read(cliOpts, builtinOpts)`
 
 Reads configurations from the filesystem and the env and returns a
 [`figgy-pudding`](https://npm.im/figgy-pudding) object with the configuration
 values.
 
-If `moreOpts` is provided, it will be merged with the returned config pudding,
-shadowing any read values.
+If `cliOpts` is provided, it will be merged with the returned config pudding,
+shadowing any read values. These are intended as CLI-provided options. Do your
+own `process.argv` parsing, though.
 
-If `readOpts.cwd` is provided, it will be used instead of `process.cwd()` as the
-starting point for config searching.
-
-If `readOpts.userconfig` is provided, it will be used as the user configuration
-file, shadowing `moreOpts.userconfig`, which is also acceptable.
+If `builtinOpts.cwd` is provided, it will be used instead of `process.cwd()` as
+the starting point for config searching.

index.js

@@ -2,6 +2,7 @@
 
 const fs = require('fs')
 const figgyPudding = require('figgy-pudding')
+const findUp = require('find-up')
 const ini = require('ini')
 const os = require('os')
 const path = require('path')
@@ -14,23 +15,15 @@ const NpmConfig = figgyPudding({}, {
 const ConfigOpts = figgyPudding({
   cache: { default: path.join(os.homedir(), '.npm') },
   cwd: { default: () => process.cwd() },
+  globalconfig: {
+    default: () => path.join(getGlobalPrefix(), 'etc', 'npmrc')
+  },
   userconfig: { default: path.join(os.homedir(), '.npmrc') }
 })
 
 module.exports.read = getNpmConfig
-function getNpmConfig (_opts, configOpts) {
-  const opts = NpmConfig(_opts)
-  const copts = ConfigOpts(configOpts)
-  const configs = copts.cwd.split(path.sep).reduce((acc, next) => {
-    acc.path = path.join(acc.path, next)
-    acc.configs.push(maybeReadIni(path.join(acc.path, '.npmrc')))
-    acc.configs.push(maybeReadIni(path.join(acc.path, 'npmrc')))
-    return acc
-  }, {
-    path: '',
-    configs: []
-  }).configs.concat(
-  ).filter(x => x)
+function getNpmConfig (_opts, _builtin) {
+  const builtin = ConfigOpts(_builtin)
   const env = Object.keys(process.env).reduce((acc, key) => {
     if (key.match(/^npm_config_/i)) {
       const newKey = key.toLowerCase()
@@ -40,10 +33,25 @@ function getNpmConfig (_opts, configOpts) {
     }
     return acc
   }, {})
-  const userconfig = maybeReadIni(
-    env.userconfig || copts.userconfig || opts.userconfig
+  const cli = NpmConfig(_opts)
+  const userConfPath = (
+    builtin.userconfig ||
+    cli.userconfig ||
+    env.userconfig
+  )
+  const user = userConfPath && maybeReadIni(userConfPath)
+  const globalConfPath = (
+    builtin.globalconfig ||
+    cli.globalconfig ||
+    env.globalconfig
   )
-  const newOpts = NpmConfig(...configs, userconfig, env, _opts)
+  const global = globalConfPath && maybeReadIni(globalConfPath)
+  const projConfPath = findUp.sync(['.npmrc', 'npmrc'], { cwd: builtin.cwd })
+  let proj
+  if (projConfPath && projConfPath !== userConfPath) {
+    proj = maybeReadIni(projConfPath)
+  }
+  const newOpts = NpmConfig(builtin, global, user, proj, env, cli)
   if (newOpts.cache) {
     return newOpts.concat({
       cache: path.join(newOpts.cache, '_cacache')
@@ -66,3 +74,20 @@ function maybeReadIni (f) {
   }
   return ini.parse(txt)
 }
+
+function getGlobalPrefix () {
+  if (process.env.PREFIX) {
+    return process.env.PREFIX
+  } else if (process.platform === 'win32') {
+    // c:\node\node.exe --> prefix=c:\node\
+    return path.dirname(process.execPath)
+  } else {
+    // /usr/local/bin/node --> prefix=/usr/local
+    let pref = path.dirname(path.dirname(process.execPath))
+    // destdir only is respected on Unix
+    if (process.env.DESTDIR) {
+      pref = path.join(process.env.DESTDIR, pref)
+    }
+    return pref
+  }
+}

package-lock.json

@@ -32,6 +32,7 @@
   "homepage": "https://npmjs.com/package/libnpmconfig",
   "dependencies": {
     "figgy-pudding": "^3.5.1",
+    "find-up": "^3.0.0",
     "ini": "^1.3.5"
   }
 }