Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Retrieve unannotated Git tags too #12

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Retrieve unannotated Git tags too #12

merged 2 commits into from
Apr 14, 2021

Conversation

wraithgar
Copy link
Member

Unannotated Git tags should be considered alongside annotated tags when
retrieving a version from Git.

Compared to annotated tags, unannotated tags do not contain a distinct
commit message or metadata, but neither are needed to retrieve version name.

See: https://git-scm.com/docs/git-describe#Documentation/git-describe.txt---tags

References

Cherry-pick from #5

Unannotated Git tags should be considered alongside annotated tags when
retrieving a version from Git.

Compared to annotated tags, unannotated tags do not contain a distinct
commit message or metadata, but neither are needed to retrieve version name.

See: https://git-scm.com/docs/git-describe#Documentation/git-describe.txt---tags
@wraithgar
Copy link
Member Author

@isaacs and @nlf both reviewed this out of band.

@wraithgar wraithgar merged commit 8be4971 into main Apr 14, 2021
@wraithgar wraithgar deleted the gar/unannotated-tag branch April 14, 2021 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants