This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
When replacing an existing module with a bundled one, remove it first #10192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarna
force-pushed
the
iarna/fix-bundled
branch
from
7452ff5
to
0b471f7
Compare
|
(For deploy monday with a special 3.3.12 release) |
|
This landed in 3.3.12 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a bundled module is going to be replacing a module that's currently on disk (for instance, when you upgrade a module that includes bundled dependencies) we want to select the version from the bundle in preference over the one that was there previously.
We achieve this by removing the obsoleted module before extracting the bundled dependency.
This fixes the problems npm is currently seeing in Travis, where it has trouble upgrading to 3.3.11 from a 2.x branch.