Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Improvements to a handful of tests #12851

Closed
wants to merge 5 commits into from
Closed

Improvements to a handful of tests #12851

wants to merge 5 commits into from

Conversation

iarna
Copy link
Contributor

@iarna iarna commented May 26, 2016

These were written while debugging the changes in #12775.

@iarna iarna force-pushed the iarna/misc-test-improvements branch from 122cca6 to 814f38f Compare May 26, 2016 05:47
@zkat
Copy link
Contributor

zkat commented May 26, 2016

LGTM once npm t passes (there were a couple of standard things). I'm excited to use t.comment more :D

@zkat zkat added in-progress and removed review labels May 26, 2016
@iarna iarna force-pushed the iarna/misc-test-improvements branch from fa3ce76 to 826bc5f Compare May 26, 2016 21:10
@zkat zkat modified the milestone: next May 26, 2016
zkat pushed a commit that referenced this pull request May 26, 2016
@iarna @zkat
test: rewrite shrinkwrap-dev-dependency as common.npm
fbec9fd 
Reviewed-By: @zkat
Credit: @iarna
PR-URL: #12851
zkat pushed a commit that referenced this pull request May 26, 2016
@iarna @zkat
test: Improve diagnostics for shrinkwrap-scoped-auth
ca0baa4 
Reviewed-By: @zkat
Credit: @iarna
PR-URL: #12851
zkat pushed a commit that referenced this pull request May 26, 2016
@iarna @zkat
test: cleanup outdated-symlink
bf7f7f2 
Reviewed-By: @zkat
Credit: @iarna
PR-URL: #12851
zkat pushed a commit that referenced this pull request May 26, 2016
@iarna @zkat
test: cleanup rm-linked
3bc4a8e 
Reviewed-By: @zkat
Credit: @iarna
PR-URL: #12851
zkat pushed a commit that referenced this pull request May 26, 2016
@iarna @zkat
test: Rewrite shrinkwrap-prod-dependency-also to use common.npm
9fd04dd 
Reviewed-By: @zkat
Credit: @iarna
PR-URL: #12851
@zkat
Copy link
Contributor

zkat commented May 27, 2016

This was included in npm@3.9.4. Thanks! 🎉

@zkat zkat closed this May 27, 2016
@iarna iarna deleted the iarna/misc-test-improvements branch June 17, 2016 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
merge-to-latest target-latest
Projects
None yet
Milestone
3.9.4
Development

Successfully merging this pull request may close these issues.
2 participants
@iarna @zkat