This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Fixes #13973 #14030 #14032
Closed
Fixes #13973 #14030 #14032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblg
force-pushed
the
iss-13973-npm-view-undefined
branch
from
6ca3389
to
f87bcb0
Compare
|
Are the appveyor checks expected to pass? It looks like they've been failing a lot (https://ci.appveyor.com/project/npm/npm/history) |
|
Our AppVeyor config currently has some bugs around git paths that stop it from completing successfully (even though we can complete testing on Windows locally). |
iarna
approved these changes
Oct 3, 2016
|
This has been merged into the |
iarna
pushed a commit
that referenced
this pull request
Oct 6, 2016
iarna
pushed a commit
that referenced
this pull request
Oct 6, 2016
In npm@2 multiple results were printed with filenames inbetween, resulting in a stream of plaintext mixed with JSON. This was pretty undesirable. Previously in, npm@3 the "best" version from the list was picked and shown, with no facility for getting multiple results. This changes npm@3 to return an array of matching results. Fixes: #14030 Credit: @roblg Reviewed-By: @iarna PR-URL: #14032
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
npm showfor an unpublished version print empty string, regardless of whether--jsonis passed. As a (intentional) side effect of making it return empty string for--json, it fixes #14030.Empty string for
--jsonmight be the wrong thing, but it's what npm2 did, and it seemed weird at first blush for--jsonto printundefined, since I don't think that's valid JSON.Approach: wrap some stuff towards the end of
printDatain a--jsoncheck, since it doesn't seem like it should apply if we're not printing JSON. The check forif (!msg)was what was ultimately causing theundefinedto be printed, and it seems like we should be going into that branch (line 283 in the patch) if we have nomsgJsondata to begin with.LMK if there's anything I can clean up here (or if I'm way off base). Thanks!
Commits
13973: npm show w/ undefined version prints 'undefined'
14030: npm show --json w/ semver range prints single result