This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
view: wait until write completes to call cb #16791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
May 30, 2017
MylesBorins
added a commit
to MylesBorins/node
that referenced
this pull request
May 30, 2017
This floats npm/npm#16791 onto npm v5.0.0 to fix an edge case that was found in citgm
jasnell
pushed a commit
to nodejs/node
that referenced
this pull request
May 30, 2017
This floats npm/npm#16791 onto npm v5.0.0 to fix an edge case that was found in citgm PR-URL: #13305 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
jasnell
pushed a commit
to nodejs/node
that referenced
this pull request
May 30, 2017
This floats npm/npm#16791 onto npm v5.0.0 to fix an edge case that was found in citgm PR-URL: #13305 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
|
node is using this patch now, so I'm just gonna merge it, tbh |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16780