Treat lack of requirement name as failure to find it

[tmct]

This should fix #9669

[iarna]

@tmct: npm install http://path/to/tarball.tgz is a valid argument that doesn't have a name.

[iarna]

That being said, markDeps is called in such a way that it absolutely should not be able to be passed a spec that doesn't have a name part. As such, I think this is papering over some larger issue...

[iarna]

And yeah, wow, #9669 is definitely not valid and should be exploding earlier and in a more informative manner. =D

[iarna]

I like this patch by the way – recalculateMetadata (and thus markDeps) need to be resilient to bad data, but to fix #9669 we're going to need an earlier error check I think (before recalculateMetadata is even called).

[tmct]

Yes, #9669 is very invalid; even the reporter says so :) I initially dived into this expecting to be adding a more informative error message as othiym23 suggested, but putting in this later defensive check seemed like a good first step (and made the resulting error much more sane!)

I'll have a look tomorrow to see where I'd add the earlier error check.

[iarna]

Hi, thank you for this! It shipped with 3.3.7 just yesterday. =)

[tmct]

No problem! Great news - thanks for using it :)