Avoid processing logs if the level is lower than log.level #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in npm#36 the `log.log` function will do processing of log messages even if the `log.level` is higher than the message level. This change will break systems expecting the event emitter to emit log messages for every call to `log.log` as well as having `log.record` only contain a list of messages that have the appropriate level
| @@ -2,7 +2,7 @@ | |||
| "author": "Isaac Z. Schlueter <i@izs.me> (http://blog.izs.me/)", | |||
| "name": "npmlog", | |||
| "description": "logger for npm", | |||
| "version": "3.0.0", | |||
| "version": "4.0.0", | |||
There was a problem hiding this comment.
We bump versions as a part of the release process. Please don't bump them in your PR.
|
I left some inline source comments, but let me back track… I don't think we can accept this, as |
|
Long term, I suspect we may separate those concerns, at which point we might be able to do something like what you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #36 the
log.logfunction will do processing of log messages even if thelog.levelis higher than the message level.This change will break systems expecting the event emitter to emit log messages for every call to
log.logas well as havinglog.recordonly contain a list of messages that have the appropriate level