fix(exec): fixed unix binary pathing issues (#120)

with special characters, which were incorrectly escaped with surrounding
quotation marks causing child_process.spawn to throw an ENOENT error.

Author: chrmoritz

index.js

@@ -232,7 +232,7 @@ function installPackages (specs, prefix, opts) {
       return opts.npm
     }
   }).then(npmPath => {
-    return child.escapeArg(npmPath, true)
+    return process.platform === 'win32' ? child.escapeArg(npmPath, true) : npmPath
   }).then(npmPath => {
     return child.spawn(npmPath, args, {
       stdio: [0, 'pipe', opts.q ? 'ignore' : 2]

test/index.js

@@ -98,13 +98,22 @@ test('installPackages unit', t => {
           const err = new Error('npm failed')
           err.exitCode = 123
           return Promise.reject(err)
+        } else if (args[2] === 'pathTest') {
+          return Promise.resolve({
+            stdout: JSON.stringify(npmPath)
+          })
         } else {
           return Promise.resolve({
             stdout: JSON.stringify([].slice.call(arguments))
           })
         }
       },
       escapeArg (arg) {
+        if (arg === '/f@ke_/path to/node'){
+          return '\'/f@ke_/path to/node\''
+        } else if (arg === 'C:\\f@ke_\\path to\\node'){
+          return '"C:\\f@ke_\\path to\\node"'
+        }
         return arg
       }
     }
@@ -141,6 +150,22 @@ test('installPackages unit', t => {
       )
       t.equal(err.exitCode, 123, 'error has exitCode')
     })
+  }).then(() => {
+    const nodePath = process.argv[0]
+    process.argv[0] = isWindows ? 'C:\\f@ke_\\path to\\node' : '/f@ke_/path to/node'
+    return installPkgs(['pathTest'], 'myprefix', {
+      npm: NPM_PATH
+    }).then((npmPath) => {
+      process.argv[0] = nodePath
+      if (isWindows){
+        t.equal(npmPath, '"C:\\f@ke_\\path to\\node"', 'incorrectly escaped path win32')
+      } else {
+        t.equal(npmPath, '/f@ke_/path to/node', 'incorrectly escaped path *nix')
+      }
+    }, (e) => {
+      process.argv[0] = nodePath
+      throw new Error('should not have failed')
+    })
   })
 })