This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
feat: install addon from URL rather than npm module #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bcoe
commented
May 12, 2016
bcoe
commented
- this makes it easier for other on-prem products to integrate with npm Enteprise (since they can generate meta-information specific to their addon).
- I received feedback that forcing people to publish a module for their addon feels weird.
- It cuts off the discussion about what scopes should be used for addons at the pass.
|
Changes Unknown when pulling f84f1df on on-prem-addons into * on master*. |
| }, function (err, res, meta) { | ||
| if (err) return deferred.reject(err) | ||
| if (res.statusCode >= 400) { | ||
| var msg = figures.cross + ' could not find addon "' + argv.addon + '" in registry ' + argv.registry |
There was a problem hiding this comment.
This error message seems a little off since we're not using a registry here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.