This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
Use os.tmpdir() for temp-dirs #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping maybe we should close the issue here and in npm if the change is not wanted which is okay for me. |
|
I have same issue, vote for merge. |
|
@isaacs Could we please get this merged, this is causing trouble for me when using |
|
👍 |
The former implementation preferred /home/{username}/tmp on unix
which caused errors for users that had different permissions on
their tmp-folder in their home, like root as owner from a previous
sudo-command.
The new implementation uses os.tmpdir()
This fixes: isaacs/npm#3470
|
merged as d6eddbc and released as 0.1.0 |
|
@robertkowalski yay, less code, less problems 😄 How can we get this fix? Update Thank you! |
|
@allaire will keep you posted in npm/npm#3470 - should be included in one of the next versions of npm. |
|
@robertkowalski Good thanks!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former implementation preferred /home/{username}/tmp on unix
which caused errors for users that had different permissions on
their tmp-folder in their home, like root as owner from a previous
sudo-command.
The new implementation uses a plain os.tmpdir() from node.core.
os.tmpdir in node core seems to be essentially the same as this function, with the small difference that not every process.env-variable are used on windows
I first thought about checking for the existence of the tmp-dir and then fallback to the /home/{username}/tmp folder but this makes no sense as the system must have the sytsem-/tmp dirs.
This fixes: isaacs/npm#3470