Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix tests for zlib differences between node versions #340

Merged
merged 1 commit into from
Dec 1, 2023
Merged

chore: fix tests for zlib differences between node versions #340

merged 1 commit into from
Dec 1, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Dec 1, 2023 •
edited

Good explanation at nodejs/node#50138

@wraithgar wraithgar requested a review from a team as a code owner December 1, 2023 16:19
fritzy
fritzy approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@fritzy fritzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, although the underlying issue is worrying for lockfiles.

@wraithgar
Copy link
Member Author

@fritzy this won't affect lockfiles. We already knew zlib wasn't deterministic, we just didn't hit it yet on smaller data sets. We only zip up the tarball once, after that it's the same content with the same hash every time (git refs notwithstanding, which intentionally don't have shasums verified/locked.

@wraithgar wraithgar merged commit a06a459 into main Dec 1, 2023
16 checks passed
@wraithgar wraithgar deleted the gar/zlib branch December 1, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzy fritzy fritzy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wraithgar @fritzy