Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

Search instead of direct compare when checking install script #23

Closed
wants to merge 1 commit into from
Closed

Search instead of direct compare when checking install script #23

wants to merge 1 commit into from

Conversation

mscdex
Copy link

@mscdex mscdex commented Apr 28, 2013

Some modules are using variations on "node-gyp rebuild" in their install scripts (e.g. ws as of this writing), so it would be nice to instead do a substring search instead of an exact comparison. Making this change will prevent the need to manually set 'gypfile' to true for such packages.

@wolfeidau
Copy link

It would be nice to get this in sooner rather than later to ensure there is an accurate picture of which modules have gypfiles and which don't.

As per https://github.com/isaacs/npm/issues/1891

@isaacs
Copy link
Contributor

isaacs commented Jul 2, 2013

That flag is just there to specify that we read a gypfile to fill in the scripts field implicitly. It's not intended to be used for any other purpose, or to be set by the author.

If you want to run analytics on who's using which scripts, use this view: https://isaacs.iriscouch.com/registry/_design/app/_list/scripts/scripts?scripts=install,preinstall,postinstall&match=node-gyp

@isaacs
Copy link
Contributor

isaacs commented Jul 2, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants