Search instead of direct compare when checking install script #23

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

mscdex commented Apr 28, 2013

Some modules are using variations on "node-gyp rebuild" in their install scripts (e.g. ws as of this writing), so it would be nice to instead do a substring search instead of an exact comparison. Making this change will prevent the need to manually set 'gypfile' to true for such packages.

mscdex referenced this pull request in websockets/ws Apr 28, 2013

Merged

Added gypfile flag to package.json #185

It would be nice to get this in sooner rather than later to ensure there is an accurate picture of which modules have gypfiles and which don't.

As per isaacs/npm#1891

Owner

isaacs commented Jul 2, 2013

That flag is just there to specify that we read a gypfile to fill in the scripts field implicitly. It's not intended to be used for any other purpose, or to be set by the author.

If you want to run analytics on who's using which scripts, use this view: https://isaacs.iriscouch.com/registry/_design/app/_list/scripts/scripts?scripts=install,preinstall,postinstall&match=node-gyp

springmeyer referenced this pull request in mapbox/node-pre-gyp Jan 16, 2014

Closed

Port key modules to node-pre-gyp #20

isaacs closed this Mar 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment