Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing acceptedDependences to abbreviated metadata #24

Merged
merged 2 commits into from
May 7, 2024

Conversation

madorb
Copy link
Contributor

@madorb madorb commented Nov 15, 2023

acceptDependencies is returned from NPM abbreviated metadata, but is not from other repositories, specifically artifactory - leading to dependency installation issues.

I assume this is partially due at least to it not being documented here.

Edit: Also added funding as i found what i believe to be the source in the code and it contained funding but this did not. Please let me know if this is not the source of truth

@lukekarrys
Copy link
Contributor

I've confirmed both of these are in minified packuments after finding some examples in the registry:

❯ curl -sH 'Accept: application/vnd.npm.install-v1+json' https://registry.npmjs.org/tap | jq -r '.l = .["dist-tags"].latest | .versions[.l] | keys'
[
  "bin",
  "dependencies",
  "dist",
  "engines",
  "funding",
  "name",
  "version"
]
❯ curl -sH 'Accept: application/vnd.npm.install-v1+json' https://registry.npmjs.org/@alilc/lce-x6-items | jq -r '.l = .["dist-tags"].latest | .versions[.l] | keys'
[
  "acceptDependencies",
  "dependencies",
  "devDependencies",
  "directories",
  "dist",
  "name",
  "peerDependencies",
  "version"
]

@lukekarrys lukekarrys merged commit ae49abf into npm:main May 7, 2024
Copy link

@Chewypewy Chewypewy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants