-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d3-selection circular dependency errors since switch to rollup #55
Comments
That's effectively what we ended up doing: Chalkbeat@1beab0f Circular dependencies are allowed by ES modules, so it's not technically an error, and D3 is unlikely to change anytime soon. |
(You may also want to pull the sync changes that I added after realizing that missing directories on either side would throw warnings: Chalkbeat@a7bdb68) |
@thomaswilburn ah great! thank you! starting on that here — https://github.com/nprapps/dailygraphics-next/tree/ah-sync-crashes. will test and probably merge in the morning. |
Seeing a lot of this in console since we switched over to rollup for bundling:
Seems to be annoying but benign? Will try the approach mentioned here to suppress the warning: d3/d3-selection#168
The text was updated successfully, but these errors were encountered: