Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d3-selection circular dependency errors since switch to rollup #55

Closed
alykat opened this issue Jul 15, 2022 · 3 comments
Closed

d3-selection circular dependency errors since switch to rollup #55

alykat opened this issue Jul 15, 2022 · 3 comments

Comments

@alykat
Copy link
Member

alykat commented Jul 15, 2022

Seeing a lot of this in console since we switched over to rollup for bundling:

Circular dependency: ../graphics-js/node_modules/d3-selection/src/selection/index.js -> ../graphics-js/node_modules/d3-selection/src/selection/data.js -> ../graphics-js/node_modules/d3-selection/src/selection/index.js
Circular dependency: ../graphics-js/node_modules/d3-selection/src/selection/index.js -> ../graphics-js/node_modules/d3-selection/src/selection/data.js -> ../graphics-js/node_modules/d3-selection/src/selection/enter.js -> ../graphics-js/node_modules/d3-selection/src/selection/index.js
Circular dependency: ../graphics-js/node_modules/d3-selection/src/selection/index.js -> ../graphics-js/node_modules/d3-selection/src/selection/exit.js -> ../graphics-js/node_modules/d3-selection/src/selection/index.js
Circular dependency: ../graphics-js/node_modules/d3-selection/src/selection/index.js -> ../graphics-js/node_modules/d3-selection/src/selection/merge.js -> ../graphics-js/node_modules/d3-selection/src/selection/index.js
Circular dependency: ../graphics-js/node_modules/d3-selection/src/selection/index.js -> ../graphics-js/node_modules/d3-selection/src/selection/sort.js -> ../graphics-js/node_modules/d3-selection/src/selection/index.js

Seems to be annoying but benign? Will try the approach mentioned here to suppress the warning: d3/d3-selection#168

@thomaswilburn
Copy link
Contributor

That's effectively what we ended up doing: Chalkbeat@1beab0f

Circular dependencies are allowed by ES modules, so it's not technically an error, and D3 is unlikely to change anytime soon.

@thomaswilburn
Copy link
Contributor

(You may also want to pull the sync changes that I added after realizing that missing directories on either side would throw warnings: Chalkbeat@a7bdb68)

@alykat
Copy link
Member Author

alykat commented Jul 15, 2022

@thomaswilburn ah great! thank you! starting on that here — https://github.com/nprapps/dailygraphics-next/tree/ah-sync-crashes. will test and probably merge in the morning.

@alykat alykat closed this as completed Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants