Fix retention script to delete really old files #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the find command to delete old files would only delete files exactly $retention_days older than when the command is run. This means that if the script runs every day then everything should be fine and no extra data is piling up. However, if the server is off or the cron does not run for any reason then extra data will be left behind as it will be older than the retention_days parameter. After this commit, the find command will delete files older than the retention days parameter instead of exactly as old as the retention_days parameter. We also switch to ctime instead of mtime beacuse we care about when the files were created not when they were last modified.
|
👍 looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the find command to delete old files would
only delete files exactly $retention_days older than when the
command is run. This means that if the script runs every day then
everything should be fine and no extra data is piling up. However,
if the server is off or the cron does not run for any reason then
extra data will be left behind as it will be older than the
retention_days parameter.
After this commit, the find command will delete files older than
the retention days parameter instead of exactly as old as the
retention_days parameter.
We also switch to ctime instead of mtime beacuse we care about when
the files were created not when they were last modified.