Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run code coverage on more devices/presets #229

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Conversation

aloisklink
Copy link
Contributor

This PR changes the CI code to automatically calculate code coverage on all tested code.

Then, another CI job is run to combine the code coverage for the multiple presets into a single coverage file, which is then uploaded.

This means that if we do start testing OpenWRT code in GitHub actions, it will be automatically uploaded too.

It's also faster, since instead of having to build once for tests, and once for coverage, we can do both in one step.

Currently a draft, since this PR depends on #226

Run codecov for multiple CMake presets and combine them before
uploading.
@aloisklink aloisklink changed the title Run Code Coverage on more devices/presets Run code coverage on more devices/presets Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #229 (5e52e52) into main (a231aee) will increase coverage by 0.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   43.67%   44.24%   +0.56%     
==========================================
  Files         100      100              
  Lines       13178    13178              
==========================================
+ Hits         5756     5831      +75     
+ Misses       7422     7347      -75     
Impacted Files Coverage Δ
src/utils/os.c 39.35% <0.00%> (+0.64%) ⬆️
tests/capture/test_capture_service.c 70.76% <0.00%> (+3.07%) ⬆️
src/capture/middlewares_list.h 32.00% <0.00%> (+12.00%) ⬆️
.../middlewares/header_middleware/header_middleware.c 17.56% <0.00%> (+17.56%) ⬆️
...iddlewares/cleaner_middleware/cleaner_middleware.c 18.34% <0.00%> (+18.34%) ⬆️
...ture/middlewares/pcap_middleware/pcap_middleware.c 26.44% <0.00%> (+26.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@mereacre mereacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@mereacre mereacre marked this pull request as ready for review August 4, 2022 13:04
@mereacre mereacre merged commit 93df35f into main Aug 4, 2022
@mereacre mereacre deleted the code-cov-more-tests branch August 4, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants