build: download uthash and utarray from upstream #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of maintaining our own fork of uthash and utarray, we can download the upstream version. This means we have less code to test, increasing code coverage. It also makes it easier to update to a newer version in the future. The only changes we had made to our version was to use src/util/allocs.h
Codecov Report
@@ Coverage Diff @@
## main #232 +/- ##
==========================================
- Coverage 45.56% 45.52% -0.04%
==========================================
Files 108 107 -1
Lines 14949 14940 -9
==========================================
- Hits 6811 6802 -9
Misses 8138 8138
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mereacre
approved these changes
Aug 12, 2022
It's a bit too famous to delete :) The uthash library is even built-in to Ubuntu, see https://packages.ubuntu.com/jammy/uthash-dev ( Apparently there's even a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of maintaining our own fork of uthash and utarray, we can download the upstream version.
This means we have less code to test, increasing code coverage (or at least it would if they weren't C/header-only macro functions).
It also makes it easier to update to a newer version of uthash the future (for example, we are now using v2.1.0, but v2.3.0 is now out)
I had a quick look at the git history for utarray.h and uthash.h, and the only major thing that I could find is that utarray.h was modified to use src/util/allocs.h.