refactor: replace non-standard icmphdr with icmp #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `struct icmphdr` in `#include <netinit/ip_icmp.h>` is non-standard, and contains different properties on FreeBSD. Because it's only a pointer (there's no memory allocation), we might as well use the standard `struct icmp`, which is a both Linux and FreeBSD compatible superset of `struct icmphdr`.
Codecov Report
@@ Coverage Diff @@
## main #263 +/- ##
=======================================
Coverage 48.51% 48.51%
=======================================
Files 113 113
Lines 17887 17887
=======================================
Hits 8678 8678
Misses 9209 9209
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mereacre
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
struct icmphdrin#include <netinit/ip_icmp.h>is non-standard, and contains different properties on FreeBSD.Because it's only a pointer (there's no memory allocation), we might as well use the standard
struct icmp, which is a both Linux and FreeBSD compatible superset ofstruct icmphdr.