fix: fix if_nametoindex implicit declaration #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `#include <net/if.h>` where if_nametoindex was defined was not included. This doesn't cause any issues in Linux 32-bit, since there the implicit `int` and actual pointer parameter are the same size. However, on Linux 64-bit, this means that the compiler sees us passing a 64-bit pointer to a 32-bit int, so who knows what will happen.
aloisklink
deleted the
fix/fix-implicit-decleration-of-if_nametoindex
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#include <net/if.h>whereif_nametoindexwas defined was not included.This meant that C implicitly defined the function as
int if_nametoindex(int);, when the function is actuallyint if_nametoindex(char *);This doesn't cause any issues in Linux 32-bit, since there the implicit
intand actual pointer parameter are the same size.However, on Linux 64-bit, this means that the compiler sees us passing a 64-bit pointer to a 32-bit int, so who knows what will happen.