Standardise test_run_commands test
#279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document the parameters of process_callback_fn. It seems that the params buf/count do **NOT** include a NUL terminator. This means that you need to manaully use `strncpy()` to convert the data to a useable string.
test_run_command() expects that the output of `uname -s` is always "Linux\n". However, this isn't right for two reasons: - That string isn't guaranteed to be NUL-terminated, so one day it might instead be `Linux\n<some_junk_data_here>`. - On other platforms like FreeBSD, `uname -s` does not print Linux. Because of this, I've changed the test command to print "Hello World!", and to handle the NUL-terminator and some other stuff.
Codecov Report
@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 49.00% 49.04% +0.03%
==========================================
Files 116 116
Lines 18487 18495 +8
==========================================
+ Hits 9060 9070 +10
+ Misses 9427 9425 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_run_command() expects that the output of
uname -sis always "Linux\n". However, this isn't right for two reasons:Linux\n<some_junk_data_here>.uname -sdoes not print Linux.Because of this, I've changed the test command to print "Hello World!", and to handle the NUL-terminator and some other stuff.